fix(tui): update tool spacing before layout#30762
Open
kitlangton wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
renderBeforeinto a shared pre-layout lifecycle helperRoot cause
renderBeforeruns after Yoga layout and immediately before drawing. UpdatingmarginTopfrom that hook dirtied layout after scroll geometry had already been calculated, which could leave sticky-bottom transcript rendering out of sync and expose blank space until a later frame or resize.Review passes
setPreLayoutSiblingMarginRed-before-green
With only the regression-test changes applied to pre-fix
origin/dev, the sticky-bottom transition test fails immediately after mounting the separator:With this branch, the same one-render transition test passes.
Verification
bunx prettier --check src/cli/cmd/tui/util/layout.ts src/cli/cmd/tui/routes/session/index.tsx src/cli/cmd/tui/feature-plugins/system/session-v2.tsx test/cli/tui/inline-tool-wrap-snapshot.test.tsxbun run test -- test/cli/tui/inline-tool-wrap-snapshot.test.tsx(10 pass,6 snapshots)bun typecheckfrompackages/opencodegit diff --check origin/dev...HEADbun turbo typecheck(22 successful)Known lint blocker
bunx oxlint ...is blocked before source analysis by the existing.oxlintrc.jsonerror:options.typeAwareis only supported in the root config