fix(workflows): retry nix-hashes compute-hash on transient failure#30743
Open
jerome-benoit wants to merge 5 commits into
Open
fix(workflows): retry nix-hashes compute-hash on transient failure#30743jerome-benoit wants to merge 5 commits into
jerome-benoit wants to merge 5 commits into
Conversation
The compute-hash matrix step intermittently fails on transient `bun install` package resolution errors during `nix build` (e.g. run 26936133588: "error: wrangler@4.50.0 failed to resolve" for ~25 packages on macos-15-intel). Adds a 3-attempt retry loop with linear backoff (10s, 20s) around the build + hash extraction. Success criterion is unchanged (hash extracted from fakeHash mismatch log); structural failures still surface with the full log after the final attempt.
- Replace magic number 3 with MAX_ATTEMPTS variable - Use bash arithmetic for loop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #30742
Type of change
What does this PR do?
Wraps
compute-hashin.github/workflows/nix-hashes.ymlwith a 3-attempt retry loop and 10s/20s linear backoff. Successful builds short-circuit on the first attempt; structural failures still surface with the full build log.How did you verify your code works?
YAML syntax check passes. Real flaky runs will exercise the retry once merged.
Screenshots / recordings
N/A.
Checklist