fix(app): prevent nested scroll in unpaid model dialog#30718
Open
antlio wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #30717
Type of change
What does this PR do?
fixes nested scroll in the select model dialog. "Add more models" provider list had its own scroll container, so hovering it and scrolling moved only that inner list, the dialog itself wouldn't scroll, leaving the content below unreachable
How did you verify your code works?
opened the select model dialog and scrolled with the cursor over the provider list, the whole dialog now scrolls instead of getting stuck.
Screenshots / recordings
Checklist