fix(ui): dollar amounts incorrectly rendered as LaTeX inline math#30715
Open
veerbal1 wants to merge 2 commits into
Open
fix(ui): dollar amounts incorrectly rendered as LaTeX inline math#30715veerbal1 wants to merge 2 commits into
veerbal1 wants to merge 2 commits into
Conversation
Dollar amounts like $50 were incorrectly rendered as LaTeX inline math. Added escaping of $ followed by a digit to \&anomalyco#36; before markdown parsing, so the markdown parser treats them as literal text instead of math delimiters. Real LaTeX like $x^2$ is unaffected.
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dollar amounts like $50 were incorrectly rendered as LaTeX inline math. Added escaping of $ followed by a digit to $ before markdown parsing, so the markdown parser treats them as literal text instead of math delimiters. Real LaTeX like$x^2$ is unaffected.
Issue for this PR
Closes #30712
Type of change
What does this PR do?
When text contains dollar amounts (e.g. "$80 + $50 = $130"), the markdown parser's
marked-katex-extensioninterprets$...$pairs as inline LaTeX math, causing random text fragments to render in a math font.This PR escapes
$followed by a digit as the HTML entity$before markdown parsing, preventing the math parser from recognizing it as a delimiter. Real LaTeX like$x^2 + y^2$or display math$$...$$is unaffected because the$is followed by a letter or backslash, not a digit.Changes in
packages/ui/src/context/marked.tsx:renderMathInText: escape$before inline math regex runsjsParserpath: wrap the return to escape$before passing to parserHow did you verify your code works?
bun dev serve+bun run --cwd packages/app devScreenshots / recordings
Before (dollar amounts incorrectly rendered as LaTeX math):

After (dollar amounts render as plain text):

Checklist