fix(config): tolerate missing file variables in config#30708
Open
stone-w4tch3r wants to merge 2 commits into
Open
fix(config): tolerate missing file variables in config#30708stone-w4tch3r wants to merge 2 commits into
stone-w4tch3r wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes/Closes #15033
Type of change
What does this PR do?
Makes missing
{file:...}config variables resolve to an empty string instead of failing opencode start when file is not present.Existing file references are still read normally, and non-missing file read errors remain fatal (eg permissions problems).
How did you verify your code works?
bun test --timeout 30000 test/config/config.test.ts— passedbun typecheck— passedbun dev /home/myuser/myprojectwhere project-localopencode.jsonhas missing file from{file:path}in MCP section. Command succeeded, opencode loaded, MCPs were off (not all config entries properly set). Compared withopencode /home/myuser/myprojectand it fails to start (treats missing files as fatal).Screenshots / recordings
If this is a UI change, please include a screenshot or recording.
Checklist
If you do not follow this template your PR will be automatically rejected.