fix(app): show stopping state on the prompt stop button#30696
Open
ysm-dev wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #30695
Type of change
What does this PR do?
In the web UI the prompt stop button is driven only by the server
working()state, so when you interrupt a prompt nothing changes on the button for the 1-2s it takes the session to actually abort. It looks like the click didn't register, so you end up clicking again.This tracks an optimistic
abortingsignal increatePromptSubmit, set as soon as the abort request is sent and cleared once the session reports not-working (the source of truth, so a new prompt starts clean). While aborting, the stop button shows the existingSpinnerand is disabled, via a newloadingprop on the sharedIconButton.How did you verify your code works?
Tested directly in the local web UI (
opencode serve+packages/appdev): the stop button shows the spinner immediately on click and returns to the send icon once the session goes idle. Also ranbun typecheckinpackages/appandpackages/ui.Screenshots / recordings
Checklist