fix(opencode): fire read hooks for image and binary file parts#30694
Open
ulises-jeremias wants to merge 1 commit into
Open
fix(opencode): fire read hooks for image and binary file parts#30694ulises-jeremias wants to merge 1 commit into
ulises-jeremias wants to merge 1 commit into
Conversation
Contributor
Author
|
Self-review summary:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #30648
Type of change
What does this PR do?
Fixes a hook consistency gap for file parts in prompt resolution.
Previously, when resolving non-text/non-directory file parts (e.g. image/binary attachments),
SessionPrompt.resolvePartread the file directly and created a data URL without invoking plugin read hooks. As a result,tool.execute.beforedid not fire for image/binary file reads.This PR updates that branch to trigger Read-equivalent hooks:
tool.execute.beforewithargs: { filePath }tool.execute.afterwith a minimal output payload (Binary read successfully)Behavior is otherwise preserved: attachments are still forwarded as data URLs.
Also included:
log.error+Session.Event.Error)packages/opencode/test/session/prompt.test.tsverifying bothtool.execute.beforeandtool.execute.afterfire for image file parts and receive expected arguments.How did you verify your code works?
fires tool.execute.before for image file partspackages/opencode:bun test test/session/prompt.test.ts -t "fires tool.execute.before for image file parts"Cannot find module '@opencode-ai/llm'frompackages/core/src/session/event.tsScreenshots / recordings
Not included.
Checklist