fix(app): support authenticated web app manifests#30399
Open
chadvoegele wants to merge 1 commit into
Open
Conversation
Contributor
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #30405
Type of change
What does this PR do?
Adds
crossorigin="use-credentials"to the web app manifest link.MDN's Web application manifest documentation says:
Why do you need this PR?
I am running
opencode webbehind anginxreverse proxy for TLS andauthentikfor SSO authentication. I could load theopencodeweb app but the PWA option was not available. The reason was that the browser was not sending credentials for/site.webmanifestand so it was redirected to the auth page.How did you verify your code works?
I applied the patch, reloaded on mobile, and installed the PWA via the prompt.
Screenshots / recordings
N/A - link attribute change only.
Checklist
Use of AI
codexwas used to diagnose the issue and prepare the PR. The final PR and description were prepared by me, a human (@chadvoegele)