fix(session): log warning when title generation fails#29737
Open
BenSharir wants to merge 1 commit into
Open
Conversation
Replace Effect.ignore with Effect.catchCause + warning log so title generation failures are visible instead of silently swallowed. Fixes anomalyco#29734
This was referenced May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #29734
Type of change
What does this PR do?
Replaces
Effect.ignorewithEffect.catchCause+ warning log at the title generation call site. This makes title generation failures visible in logs instead of being silently swallowed.Before: failures completely silent, sessions get timestamp titles with no indication why.
After: warning logged with error details, making diagnosis possible.
This is a minimal fix (4 lines changed). For fallback model support, see PR #27939 which adds configurable fallback chains.
How did you verify your code works?
elogandCauseare already in scope (lines 83 and 48)Effect.catchCause+elog.errorpattern)Screenshots / recordings
N/A - logging change only
Checklist