fix(app): prevent TimelineRow.key crash on undefined row#29693
Open
jjserenity wants to merge 1 commit into
Open
fix(app): prevent TimelineRow.key crash on undefined row#29693jjserenity wants to merge 1 commit into
jjserenity wants to merge 1 commit into
Conversation
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #29682
Type of change
What does this PR do?
Desktop renderer crashes with
TypeError: Cannot read properties of undefined (reading '_tag')atTimelineRow.keywhen message data contains unexpected structure. This creates an infinite crash loop — Electron restarts, reloads the same session data, and crashes again.TimelineRow.keyis called fromArray.map()on timeline rows. If any row isundefined(e.g., from malformed deserialized data), accessingrow._tagthrows.Added a null guard at the top of
TimelineRow.key— ifrowis falsy, return"unknown"as the key. This prevents the renderer crash and allows the session to load gracefully.How did you verify your code works?
Changes are a single-line null guard with no side effects — the function simply returns early for falsy input. Verified the existing type signature accepts the change.
Screenshots / recordings
N/A — not a UI change.
Checklist