fix(opencode): remove shell tool detached flag to prevent zombie processes#29678
Open
JunJieLiu51520 wants to merge 1 commit into
Open
fix(opencode): remove shell tool detached flag to prevent zombie processes#29678JunJieLiu51520 wants to merge 1 commit into
JunJieLiu51520 wants to merge 1 commit into
Conversation
…esses On Linux, spawning shell children with `detached: true` calls setsid() which puts them in their own process group. Without a SIGCHLD handler, exited children become zombies. Explicit cleanup is already handled via handle.kill() in abort/timeout paths, making signal-group isolation unnecessary. Fixes anomalyco#29506
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential Duplicate FoundPR #29510 - This appears to be a duplicate of the current PR #29678. Both PRs have:
Please check PR #29510 to see if it's already merged, closed, or still in progress before proceeding with PR #29678. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #29506
Type of change
What does this PR do?
tool/shell.tsspawns child processes withdetached: trueon Linux, which callssetsid()and puts children in their own process group. When these children exit, Node.js cannot reap them because they are in a separate session, resulting in<defunct>zombie processes accumulating acrossopencode runsessions.The fix sets
detached: falseon all platforms. This is safe because:handle.exitCodehandle.kill()in abort/timeout pathsHow did you verify your code works?
Confirmed that the
cmd()function no longer passesdetached: trueon any platform. The abort/timeout kill paths remain unchanged and continue to handle process cleanup.Checklist