feat(tui): show progress and confirmation when forking a session#29651
Open
kitlangton wants to merge 1 commit into
Open
feat(tui): show progress and confirmation when forking a session#29651kitlangton wants to merge 1 commit into
kitlangton wants to merge 1 commit into
Conversation
Forking gave no feedback: the dialog stayed open during the (potentially slow) fork, then silently navigated to a near-identical copy. Now the dialog shows a "Forking session…" spinner while the fork runs, then lands on the new session with a "Forked session" toast (or an error toast on failure). Mount <Toast/> once in the app shell instead of per-route, so a toast fired around route.navigate survives the route remount.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forking gave no feedback: the dialog stayed open during the (potentially slow) fork, then silently navigated to a near-identical copy. Now the dialog shows a "Forking session…" spinner while the fork runs, then lands on the new session with a "Forked session" toast (or an error toast on failure).
Also moved
<Toast/>from per-route mounts (home.tsx, session/index.tsx) to one mount in the app shell so a toast fired aroundroute.navigate(...)survives the route remount.Verified end-to-end via tuistory; typecheck passes.
What it looks like
After picking a fork point in the Fork dialog:
Then it lands on the new (forked) session and confirms: