fix(openai): improve websocket retry handling#29645
Open
timrichardson wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Based on the search results, here are potential duplicate or related PRs: Most Relevant:
Also Related:
These PRs appear to be addressing related infrastructure around WebSocket connections and retry logic. PR #29394 in particular may be the feature that this PR is fixing. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #29646
Type of change
What does this PR do?
Handles transient OpenAI Responses websocket failures before
response.completed. The websocket pool now retries over HTTP when the socket times out or disconnects before committed output, and avoids replay once output has been emitted.It also adds deterministic websocket tests for connect timeout, idle timeout, unexpected close, and replay-safe preamble cases.
How did you verify your code works?
bun test test/plugin/openai-ws.test.tsbun turbo typecheckvia the push hookScreenshots / recordings
Not applicable; this is error and retry handling with a text retry notice.
Checklist
If you do not follow this template your PR will be automatically rejected.