fix(tui): avoid question taking over open dialog#28936
Open
julio-Cortes wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #28935
Type of change
What does this PR do?
I dont have a lot of experience on the stack, but following react-ish principles regarding hooks i just added a method to check if the dialog was open checking the size of the stack. Then if the stack is open, it doesnt allow the question or permission prompt (not sure how to call that binding) to take focus
How did you verify your code works?
Following the reproduction steps of the issue
Screenshots / recordings
Before fix:
screenrecord.mp4
After:
screenrecord.mp4
Checklist
If you do not follow this template your PR will be automatically rejected.