fix(opencode): ensure help output ends with newline#28643
Open
xmh1011 wants to merge 1 commit into
Open
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential Duplicate PRs FoundI found two related PRs that appear to be addressing the same issue:
Why they're related: All three PRs (including the current PR #28643) are specifically addressing the issue of ensuring help output ends with a newline character. PR #28622 appears to be the most recent similar attempt with nearly identical scope to the current PR. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #28606
Closes #26114
Closes #27485
Type of change
What does this PR do?
opencode --helpcan print yargs help text without a trailing newline, which leaves the next shell prompt on the same line as the final help option. This updates the sharedshow()helper to append one platform newline only when the generated help text does not already end with\n.The PR also adds regression coverage for top-level help and documented command help output so future CLI help paths keep the trailing newline while preserving the existing help snapshots. Separately, it fixes the
whenvertypo in the dev control-plane README.How did you verify your code works?
npx -y bun@1.3.14 test test/cli/help/help-snapshots.test.ts --timeout 180000npx -y bun@1.3.14 typecheckScreenshots / recordings
N/A - terminal output and documentation-only changes.
Checklist