fix(cli): handle OSC52 clipboard passthrough properly under GNU screen#28592
Open
lingfish wants to merge 1 commit into
Open
fix(cli): handle OSC52 clipboard passthrough properly under GNU screen#28592lingfish wants to merge 1 commit into
lingfish wants to merge 1 commit into
Conversation
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #28590
Type of change
What does this PR do?
writeOsc52previously wrapped all mux clients in\x1bPtmux;\x1b...\x1b\\. This only works for tmux — screen's DCS passthrough outputs the raw string, so thetmux;prefix corrupts the terminal output and scrambles the TUI display.The fix separates the tmux and GNU screen code paths:
process.env["STY"], tmux viaprocess.env["TMUX"]\x1bP\x1b]52;c;...\x07\x1b\\(notmux;prefix)MAXSTR= 768, leaving ~759 after overhead)\x1b\\\x1bP; the terminal accumulates partial OSC writes until\x07Credits to @valdemardi for identifying the issue in #26491 / #26492.
How did you verify your code works?
Tested under GNU screen and tmux with short and long text passages. Tmux path unchanged — no regression.
Screenshots / recordings
N/A
Checklist