fix(opencode): resolve shell file mentions#28588
Open
Arcadi4 wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
a6bcff7 to
3b5625a
Compare
3b5625a to
78e4340
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #28583
Type of change
What does this PR do?
Shell mode passed
@filementions as-is, so commands likecat @abc.txtfail. This PR resolves existing file mentions before shell execution to single-quoted absolute paths (like'/absolute/path/to/file.text'). Forpwsh, paths are still single-quoted but use PowerShell-compatible escaping for apostrophes.How did you verify your code works?
bun typecheckfrompackages/opencode.@file mentions.Screenshots / recordings
Checklist