fix(cli): resume sessions from stored directory#28582
Open
ualtinok wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #28581
Type of change
What does this PR do?
Resuming a local session now uses the session's stored directory when the user did not provide an explicit directory override.
This updates both local
opencode run -s/-cand root TUIopencode -spaths so they bind the local client/worker to the resolved session directory. Explicit--diror project arguments keep their existing precedence. If a stored local session directory no longer exists, direct-sfails clearly and local project-wide-cskips stale root sessions before selecting one.How did you verify your code works?
A new opencode built with this PR merged ran in home dir with a session id of a project where dir is different than home. Successfully observed cwd correctly set to the right (project's) directory.
also:
bun test test/cli/run/directory.test.ts test/cli/tui/thread.test.ts --timeout 30000bun typecheckgit diff --check upstream/dev...HEADScreenshots / recordings
Not applicable; CLI behavior change.
Checklist