test(config-markdown): lock in unquoted-colon-in-description handling#28085
Draft
PeterPonyu wants to merge 1 commit into
Draft
test(config-markdown): lock in unquoted-colon-in-description handling#28085PeterPonyu wants to merge 1 commit into
PeterPonyu wants to merge 1 commit into
Conversation
…anomalyco#25315) Adds a regression fixture and 5 assertions covering the scenario from issue anomalyco#25315: a markdown agent file whose frontmatter contains 'description: Reviews changes: returns a verdict.' (unquoted colon). Confirmed behavior on current upstream/dev: gray-matter parses the multi-token value correctly, mode/hidden/description are all preserved, and the body is extracted separately. Test passes with 5/5 assertions. The bug as reported in v1.14.30 appears already resolved on the current default branch — this PR locks the correct behavior in so future regressions don't recur.
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Based on the search results, I found one potentially related PR: Related PR:
The current PR (#28085) is test-only and locks in the fix for the unquoted-colon-in-description bug. PR #28086 seems to be testing related frontmatter description propagation behavior, so they may be part of the same feature/fix effort. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #25315
Type of change
What does this PR do?
The bug reported in #25315 (v1.14.30: hidden subagents leak into the web UI when their frontmatter
descriptioncontains an unquoted colon, e.g.description: Reviews changes: returns a verdict.) appears already resolved on currentdev.gray-matterparses the multi-token value correctly andmode,hidden,description, and the body are all preserved.This PR is test-only — no source changes. It adds a fixture
test/config/fixtures/subagent-colon-description.mdand 5 assertions intest/config/markdown.test.tsso the correct parsing is locked in against future regressions.How did you verify your code works?
cd packages/opencode && bun test test/config/markdown.test.ts— 42 pass, 0 fail. The 5 new assertions verifymode: subagent,hidden: true, the full unquoted-colon description string, and the body content are all parsed correctly from the fixture.Screenshots / recordings
N/A — no UI change.
Checklist