fix(shell): avoid non-string stdout parsing in cygpath path resolution#28075
Open
jeevan6996 wants to merge 1 commit into
Open
fix(shell): avoid non-string stdout parsing in cygpath path resolution#28075jeevan6996 wants to merge 1 commit into
jeevan6996 wants to merge 1 commit into
Conversation
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #26932
Type of change
What does this PR do?
This fixes a bash-tool failure where a non-string stdout shape could flow into a split path during Windows
cygpathresolution. I replaced thespawner.lines(...)call with explicitspawn+ stdout stream decode + exit-code check, then only parse the first line when the command succeeds.This keeps the same fallback behavior (
undefinedon failure) but removes the non-string split hazard that could abort tool execution.How did you verify your code works?
bun test test/tool/shell.test.tsfrompackages/opencode(22 passing tests)bun turbo typechecksuccessfully before branch pushScreenshots / recordings
N/A (non-UI change)
Checklist