fix: sort app sessions by updated time#27954
Draft
Hona wants to merge 1 commit into
Draft
Conversation
5b1fc4a to
a4cf0b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR: "Load more" looked random because the backend and sidebar disagreed on what "newest" meant.
From the actual local DB investigation, the API was selecting/paginating root sessions by created time, but the app sidebar displays sessions by updated time. That means a session created days ago but touched recently can be outside the first page, then appear near the top after clicking Load more. Concrete example from the repro data: "fix: ResizeObserver crash" was created-rank 22 but updated-rank 6, so it appeared around position 6 only after increasing the loaded page.
This PR keeps the API default unchanged for compatibility, but gives app consumers a way to ask for the ordering they actually display.
Summary:
Tests: