fix(plugin): refresh mutable specs during install#27940
Open
samiralibabic wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #25293
Type of change
What does this PR do?
Explicit plugin installs now refresh mutable package specs instead of reusing a stale package cache entry forever.
The cache fast path is still used for exact versions and for normal plugin loading. Only install/update paths pass
refresh: truefor mutable specs such as bare package names,@latest, ranges, git specs, and unpinned npm aliases.This is intentionally narrower than auto-updating plugins during startup. It fixes the stale
@latestinstall behavior without adding registry checks to normal TUI boot.Likely addresses #21609. Related: #26215, #18544, #23143, #23502.
How did you verify your code works?
bun test test/npm.test.tsfrompackages/corebun test test/plugin/shared.test.ts test/plugin/install.test.tsfrompackages/opencodebun typecheckfrompackages/corebun typecheckfrompackages/opencodegit diff --checkbun turbo typecheckcompleted successfullyScreenshots / recordings
Not a UI change.
Checklist