fix: recover interrupted tool and lsp warmup states#27895
Open
eatFirewood wants to merge 2 commits into
Open
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
3534458 to
21fe2d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #27871
Type of change
What does this PR do?
Fixes two ways a session can get stuck after tool/runtime interruption.
First,
readnow treats LSP warm-up as best-effort. It explicitly carries the currentInstanceRefinto the forked warm-up effect and logs any warm-up failure instead of letting that background optimization break a successful file read.Second, session cleanup now waits only for tool calls that reached
running. Apendingtool part is still incomplete input assembly, so it cannot produce a real tool result and should be marked interrupted during cleanup instead of awaited.How did you verify your code works?
bun test test/tool/read.test.tsbun test test/session/processor-effect.test.tsbun run --cwd packages/opencode typecheckbun run lint -- packages/opencode/src/tool/read.ts packages/opencode/src/session/processor.ts packages/opencode/test/tool/read.test.ts packages/opencode/test/session/processor-effect.test.tsprocessor-effect.test.tsneeds local port binding and was run outside the sandbox. Lint reports existing warnings inprocessor.ts, with no new errors.Screenshots / recordings
Not applicable, no UI change.
Checklist