Skip to content

fix(server): implement findSymbol endpoint via LSP workspaceSymbol#27773

Open
shafdev wants to merge 1 commit into
anomalyco:devfrom
shafdev:fix/find-symbol-stub-endpoint
Open

fix(server): implement findSymbol endpoint via LSP workspaceSymbol#27773
shafdev wants to merge 1 commit into
anomalyco:devfrom
shafdev:fix/find-symbol-stub-endpoint

Conversation

@shafdev
Copy link
Copy Markdown
Contributor

@shafdev shafdev commented May 15, 2026

Issue for this PR

Closes #27650

Type of change

  • Bug fix

What does this PR do?

findSymbol in handlers/file.ts was a stub returning [] unconditionally. Wires it to LSP.Service.workspaceSymbol so the endpoint actually queries active LSP servers. Also updates the test assertion which was asserting the stub behavior.

Note: PR #27643 addresses the same issue but is submitted from the dev branch directly. This PR uses a dedicated fix branch and includes a test update.

How did you verify your code works?

  • bun typecheck — no new errors
  • bun test test/server/httpapi-file.test.ts --timeout 30000 — endpoint returns 200 with array response

Screenshots / recordings

N/A

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

The findSymbol handler was a stub returning [] unconditionally.
Wire it to LSP.Service.workspaceSymbol so workspace symbol search
actually queries active LSP servers.

Closes anomalyco#27650
@github-actions github-actions Bot added contributor needs:compliance This means the issue will auto-close after 2 hours. labels May 15, 2026
@github-actions
Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

I found a potential duplicate:

PR #27643: "fix: implement /find/symbol endpoint to query LSP workspace symbols"
#27643

This PR appears to be directly addressing the same issue - implementing the /find/symbol endpoint (which is the findSymbol handler) to query LSP workspace symbols. It's likely that PR #27643 is either:

  • An earlier attempt at the same fix
  • A related PR that also addresses the workspaceSymbol integration
  • Already merged and this PR may be redundant

I also found:

PR #23612: "fix(opencode): add lsp sync range for roslyn and fix workspacesymbol query"
#23612

This is less likely to be a duplicate but may be related to LSP workspaceSymbol handling.

You should check the status of PR #27643 to determine if it's already been merged or if it's addressing the same issue.

@github-actions github-actions Bot removed the needs:compliance This means the issue will auto-close after 2 hours. label May 15, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/find/symbol endpoint returns empty array instead of LSP workspace symbols

1 participant