Revert Hono deletion and cleanup follow-up (temporary, fixes #26546)#26548
Closed
kitlangton wants to merge 1 commit into
Closed
Revert Hono deletion and cleanup follow-up (temporary, fixes #26546)#26548kitlangton wants to merge 1 commit into
kitlangton wants to merge 1 commit into
Conversation
…eanup This reverts: - 28b0359 research: delete Hono backend (do not merge) (#25667) - b24a4e8 chore(server): clean up post-Hono-deletion scar tissue (#26542) v1.14.42 broke startup for users with plugins that depend on the Hono wire format (most visibly opencode-gemini-auth, see #26546). Restoring Hono as the default backend on stable channels while we investigate the actual plugin compatibility story. OPENCODE_EXPERIMENTAL_HTTPAPI flag and dual-backend selection come back. Stable installs default to Hono; dev/beta default to HTTP API. Conflict resolution: took the pre-deletion side for control-plane schemas and the seven test files where post-deletion follow-up PRs had also touched the conflicting lines. The HTTP API code added since the deletion (compression, cors-vary, fence, lifecycle log, account error mapping, etc.) is preserved as-is — those still apply on the HTTP API path for users on dev/beta channels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts the Hono backend deletion (#25667) and its cleanup follow-up (#26542).
v1.14.42 (released after #25667) broke startup for users with plugins that depend on the Hono wire format — most visibly `opencode-gemini-auth`, see #26546. The plugin's `auth.set` call surfaces a 400 from the HTTP API, the SDK throws, the error bubbles to the top-level catch in `index.ts`, and the response body lands on stdout instead of the TUI starting.
Restoring Hono as the default backend on stable channels while we investigate the actual plugin compatibility story. The HTTP API code added between #25667 and now (compression middleware, cors-vary fix, fence layer, lifecycle log, account error mapping, validation error response shape, etc.) is preserved — those still apply on the HTTP API path for users on `dev`/`beta` channels (`OPENCODE_EXPERIMENTAL_HTTPAPI` defaults on for those).
Conflict resolution
7 conflicts in test files + `control-plane/types.ts`. All resolved by taking the pre-deletion side (where Hono code lives), since the goal is to restore the prior state. Post-deletion follow-up PRs that re-touched these files have minor formatting overlaps; the substance of those PRs (test expansions, etc.) remains in adjacent files.
After this lands
Test plan