Skip to content

fix(npm): resolve cached package name from install dir for non-registry specs#25744

Closed
sjawhar wants to merge 1 commit into
anomalyco:devfrom
sjawhar:fix/npm-cache-name-resolution
Closed

fix(npm): resolve cached package name from install dir for non-registry specs#25744
sjawhar wants to merge 1 commit into
anomalyco:devfrom
sjawhar:fix/npm-cache-name-resolution

Conversation

@sjawhar
Copy link
Copy Markdown

@sjawhar sjawhar commented May 4, 2026 •
edited
Loading

Issue for this PR

Closes #23653

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Fixes the regression introduced in #18308 where Npm.add() cached install dirs keyed on npa(pkg).name, which returns undefined for non-registry specs (remote tarball URLs, git+https://, GitHub shorthand like Edison-A-N/opencode-preview, file: paths). On a cache hit the code then called resolveEntryPoint(undefined, ...), breaking subsequent installs of these specs.

The fix recovers the actual installed package name by reading the install-root package.json (written by Arborist on the initial install) and using its first dependency entry — matching what the fresh-install path computes from the arborist tree below it.

Why this works:

  • For registry specs (lodash@4), npa(pkg).name returns the package name as before — unchanged.
  • For non-registry specs with a previously installed cache, the cached package.json contains a dependencies map whose first key is the actual installed package name (Arborist writes this when reifying). We read that name and resolve against node_modules/<actual-name>/ correctly.
  • For cache directory exists but no parseable deps (corrupted/partial cache), we fall through to the Arborist install path so the package gets re-reified instead of returning a broken entrypoint.

How did you verify your code works?

  • New unit tests in packages/opencode/test/npm.test.ts covering:
    • Cache-hit path returning the actual installed package name (not the npa-derived undefined)
    • Re-install behavior when the cache directory exists without the package installed (corrupted cache recovery)
    • Registry-spec path unchanged
  • Full packages/opencode and packages/core test suites run locally — pass
  • bun typecheck passes on both packages

Screenshots / recordings

N/A — no UI changes.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions github-actions Bot added needs:compliance This means the issue will auto-close after 2 hours. needs:issue labels May 4, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions github-actions Bot removed needs:issue needs:compliance This means the issue will auto-close after 2 hours. labels May 4, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Thanks for updating your PR! It now meets our contributing guidelines. 👍

@legion-implementer legion-implementer Bot force-pushed the fix/npm-cache-name-resolution branch 2 times, most recently from c04201e to afbbdb5 Compare May 10, 2026 20:33
@legion-implementer legion-implementer Bot force-pushed the fix/npm-cache-name-resolution branch 2 times, most recently from 86adf74 to 2cb4a61 Compare May 28, 2026 18:11
@sjawhar
fix(npm): resolve cached package name from install dir for non-regist…
26c9a51 
…ry specs

For non-registry specs (remote tarball URLs, git+https://, github: shorthand,
file: paths), npa(pkg).name returns undefined - only registry packages have
inferable names from the spec alone. Read the install-root package.json
written by Arborist on the initial install to recover the actual installed
package name from its first dependency entry.

When the cache directory exists but is empty (no package.json), fall through
to the Arborist install path instead of returning a likely-failing entrypoint
resolution. This preserves upstream's anomalyco#25354 fix for empty cache dirs while
adding the cached-name resolution for non-registry specs.
@legion-implementer legion-implementer Bot force-pushed the fix/npm-cache-name-resolution branch from 2cb4a61 to 26c9a51 Compare May 29, 2026 07:44
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

@github-actions github-actions Bot closed this Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

automated-pr-cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] GitHub shorthand plugin specs fail to resolve after arborist refactor

1 participant

@sjawhar