fix: tolerate outputSchema compilation failures in MCP tool discovery#21592
Open
claygeo wants to merge 1 commit intoanomalyco:devfrom
Open
fix: tolerate outputSchema compilation failures in MCP tool discovery#21592claygeo wants to merge 1 commit intoanomalyco:devfrom
claygeo wants to merge 1 commit intoanomalyco:devfrom
Conversation
When an MCP server returns outputSchema in its tools/list response, the SDK's default AjvJsonSchemaValidator can throw during schema compilation, causing listTools() to fail entirely. This makes the server show "Failed to get tools" even though the tools themselves are valid. opencode doesn't use output schemas (only inputSchema is read in convertMcpTool), so validation failures should be non-fatal. Wrap AjvJsonSchemaValidator with a TolerantJsonSchemaValidator that catches compilation errors and returns a permissive fallback. Pass it to both Client constructors via the SDK's jsonSchemaValidator option. Closes anomalyco#21373
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #21591
Type of change
What does this PR do?
When an MCP server returns
outputSchemain itstools/listresponse, the SDK'sAjvJsonSchemaValidator.getValidator()callsajv.compile(schema)with no try/catch. If the schema uses unsupported keywords, it throws and the entirelistTools()call fails, making the server show "Failed to get tools."opencode never uses
outputSchema(onlyinputSchemainconvertMcpTool()), so these compilation failures shouldn't block tool discovery.The fix wraps
AjvJsonSchemaValidatorin aTolerantJsonSchemaValidatorthat catchesgetValidator()failures and returns a permissive fallback. Uses the SDK'sjsonSchemaValidatorextension point, no monkey-patching. One file changed, ~20 lines added.How did you verify your code works?
listTools()→cacheToolMetadata()→getValidator(outputSchema)— confirmed the wrapper intercepts the throwScreenshots / recordings
Not a UI change.
Checklist