fix(core): respect explicit session ids in session create#21571
Open
sjawhar wants to merge 1 commit intoanomalyco:devfrom
Open
fix(core): respect explicit session ids in session create#21571sjawhar wants to merge 1 commit intoanomalyco:devfrom
sjawhar wants to merge 1 commit intoanomalyco:devfrom
Conversation
c5d0d3e to
9db316e
Compare
07489a3 to
e71f234
Compare
e71f234 to
a88683b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #21568
Type of change
What does this PR do?
This makes
POST /sessionrespect an explicitidwhen one is provided.Before this change, the server-side session creation path ignored
id, so creating the same explicit session twice returned 200 twice and the existingDuplicateIDError/ 409 path was unreachable.This PR wires
idthroughSession.create, maps duplicate session insertions toDuplicateIDError, updates the route error schema to include 409, and updates the generated SDK/types to match the actual API.How did you verify your code works?
cd packages/opencode && bun test test/server/session-messages.test.tscd packages/opencode && bun typecheckcd packages/sdk/js && bun typecheckopencode serve:POST /sessionwith explicitidreturned 200DuplicateIDErrorScreenshots / recordings
N/A (API-only change)
Checklist