fix(session): stop replaying compaction recovery as user prompts#18873
fix(session): stop replaying compaction recovery as user prompts#18873Haohao-end wants to merge 1 commit into
Conversation
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found one potentially related PR: PR #13940: fix(compaction): use neutral text for compaction replay message This PR appears related as it addresses a similar concern about how compaction replay messages are handled and presented. Both PRs seem to be addressing issues with compaction recovery messaging, though PR #18873 (the current PR) appears to be a more comprehensive fix that stops serializing compaction parts into fake user prompts entirely, while #13940 may have focused on making the replay message more neutral. The other PRs found (#14826, #16073, #17936) are related to compaction and recovery features but don't appear to directly duplicate the specific issue being fixed here. |
|
Thanks! I checked the duplicate hint. My change is narrower in implementation shape: it removes the compaction replay fake user prompt path and keeps recovery instructions as ignored synthetic state promoted through system prompt construction, instead of replaying them as user input. All required checks passed, including unit/e2e/typecheck on Linux and Windows. |
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
Issue for this PR
Closes #13838
Type of change
What does this PR do?
This fixes a compaction recovery bug where recovery state could be replayed back to the model as if it were a real user turn.
Before this change, compaction-related replay could introduce fake user-facing prompts such as
What did we do so far?, and the auto-compaction continue path also created a synthetic user message. That made the next model turn look like the user was asking for a recap / continuation, which could trigger an unwanted summary instead of normal recovery.This PR makes three small changes:
compactionparts into a fake user text promptThis works because the model no longer sees compaction recovery as fresh user intent. It still gets the recovery instruction needed to continue after compaction, but that instruction is no longer shaped like a real user message.
How did you verify your code works?
Tested locally with:
bun test test/session/message-v2.test.tsbun turbo typecheckI also checked the diff to make sure the change stayed limited to the compaction/replay path and did not alter unrelated message handling.
Screenshots / recordings
N/A
Checklist