Skip to content

fix(web): set locale cookie on docs language switch#17667

Closed
ashmod wants to merge 1 commit into
anomalyco:devfrom
ashmod:fix/docs-language-switch
Closed

fix(web): set locale cookie on docs language switch#17667
ashmod wants to merge 1 commit into
anomalyco:devfrom
ashmod:fix/docs-language-switch

Conversation

@ashmod
Copy link
Copy Markdown

@ashmod ashmod commented Mar 15, 2026 •
edited
Loading

Issue for this PR

Closes #12063
Closes #14409
Closes #14997
Closes #15194
Closes #15904
Closes #15984
Closes #16278
Closes #17665
Closes #18541
Closes #22415

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

The docs language selector can't switch back to English from any other language. English is the root locale (/docs/) while others have a prefix (/docs/fr/). When navigating to /docs/, the console proxy falls back to the oc_locale cookie to detect locale, but the cookie still holds the previous language, so it serves that language again.

This PR overrides Starlight's LanguageSelect component to set the oc_locale cookie to the correct value before window.location.pathname triggers navigation. The proxy then reads the updated cookie and serves the right locale.

How did you verify your code works?

Ran the docs site and console app locally. Switched from English to French, then back to English - previously stuck on French, now correctly returns to English. Tested multiple language round-trips (English -> French -> English -> Chinese) and verified the oc_locale cookie updates correctly in devtools after each switch.

Screenshots / recordings

If this is a UI change, please include a screenshot or recording.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

If you do not follow this template your PR will be automatically rejected.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 15, 2026

The following comment was made by an LLM, it may be inaccurate:

Potential Duplicate PRs Found

These PRs appear to address similar locale/language switching issues:

  1. fix(web): persist locale cookie on canonical docs pages #15938 - fix(web): persist locale cookie on canonical docs pages

  2. fix(web): update oc_locale cookie on language change #16279 - fix(web): update oc_locale cookie on language change

  3. refactor(www): stabilize locale routing #16402 - refactor(www): stabilize locale routing

Note: PR #17667 (current PR) references issue #17665. You should verify whether these older PRs were closed without fixing the issue, or if they took a different approach that didn't fully resolve the language switching problem.

@github-actions github-actions Bot mentioned this pull request Mar 16, 2026
Open
@rekram1-node
Copy link
Copy Markdown
Collaborator

rekram1-node commented May 15, 2026

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment