Skip to content

feat(tui): add double/triple click copy selection#17465

Closed
timwuhaotian wants to merge 12 commits into
anomalyco:devfrom
timwuhaotian:feat/dclick-triclick-cp
Closed

feat(tui): add double/triple click copy selection#17465
timwuhaotian wants to merge 12 commits into
anomalyco:devfrom
timwuhaotian:feat/dclick-triclick-cp

Conversation

@timwuhaotian
Copy link
Copy Markdown

@timwuhaotian timwuhaotian commented Mar 14, 2026 •
edited
Loading

Issue for this PR

Closes #3091
Closes #7336

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

This adds mouse word/line copy support to the TUI.

  • Double click selects and copies the visible word under the cursor.
  • Triple click selects and copies the visible line.
  • The copied selection stays highlighted until the next interaction.

The selection is computed from the rendered terminal buffer, so it matches what the user actually sees, including concealed markdown/code and wide characters.

Existing drag-copy and right-click copy behavior stays the same. Clickable TUI elements also skip their normal action while a text selection is active.

How did you verify your code works?

I ran:

  • bun test test/cli/tui
  • bun typecheck

I also added TUI tests for:

  • single click does not create a custom selection
  • concealed markdown/code double click selects the visible word
  • wide character double click works from either half of the cell
  • triple click selects the full visible line across sibling selectable elements with layout gaps
  • existing drag-copy behavior still works
  • streak timeout and target changes reset correctly

Screenshots / recordings

  • bun dev

dclick-triclick-cp

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

If you do not follow this template your PR will be automatically rejected.

@timwuhaotian
feat: implement selection functionality in TUI components
949e27d 
- Added selection utility functions to manage text selection in the TUI.
- Integrated selection checks in various components to prevent actions when text is selected.
- Updated dialog components to handle selection state during user interactions.
- Enhanced mouse event handling to support double and triple click selections.
- Added tests for selection behavior, including single, double, and triple click scenarios.
@github-actions github-actions Bot added the needs:compliance This means the issue will auto-close after 2 hours. label Mar 14, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 14, 2026

The following comment was made by an LLM, it may be inaccurate:

I found several potentially related PRs:

  1. PR feat(tui): add double-click to copy word #6285 - feat(tui): add double-click to copy word

  2. PR fix(tui): support middle-click paste from X11 primary selection #16379 - fix(tui): support middle-click paste from X11 primary selection

    • Related to selection/paste functionality in TUI components

  3. PR fix:solved the copy issue in TUI #14101 - fix: solved the copy issue in TUI

    • Related to copy functionality in TUI

  4. PR fix(tui): fix Ctrl+V paste on Windows/WSL2 (#6560 and #8209) #8626 - fix(tui): fix Ctrl+V paste on Windows/WSL2

    • Related to paste/clipboard handling in TUI

  5. PR feat(opencode): add linux clipboard toast warnings  #10332 - feat(opencode): add linux clipboard toast warnings

    • Related to clipboard operations in TUI

The most directly related PR is #6285 which appears to implement very similar double-click selection/copy functionality for words. You may want to check if that PR was already merged or if there's overlap with the current implementation.

@github-actions github-actions Bot removed the needs:compliance This means the issue will auto-close after 2 hours. label Mar 14, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 14, 2026

Thanks for updating your PR! It now meets our contributing guidelines. 👍

@timwuhaotian timwuhaotian changed the title feat: implement selection and copy functionality in TUI components via double click (word) and triple click (row) feat(tui): add double/triple click copy selection Mar 14, 2026
@timwuhaotian timwuhaotian marked this pull request as ready for review March 14, 2026 08:23
@rekram1-node
Copy link
Copy Markdown
Collaborator

rekram1-node commented May 15, 2026

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fails to select word on dual click add double click on message text to copy paragraph

2 participants

@timwuhaotian @rekram1-node