fix: attachment bugs#1335
Merged
Merged
Conversation
Member
|
did the assistant call the read tool on the attached file immediately? that's the only potential side effect i can imagine creeping in. @thdxr any other issues you can think of using absolute paths for attachments like this? |
Collaborator
Author
|
I think the behavior read tool wise remains the same unless I misunderstand, here is a share link: https://dev.opencode.ai/s/0yPBxwRs Excerpt: {
"id": "prt_8472f0c64001jdr4sn8Vu2jMiW",
"messageID": "msg_8472f0c59001W6y6LpDGiWWp7Q",
"sessionID": "ses_7b8d0f3abffeBkSA340yPBxwRs",
"type": "text",
"synthetic": true,
"text": "Called the Read tool with the following input: {\"filePath\":\"/Users/aidencline/Desktop/testing/hello.txt\"}"
},
{
"id": "prt_8472f0c640028HAnuEfDEQMgSZ",
"messageID": "msg_8472f0c59001W6y6LpDGiWWp7Q",
"sessionID": "ses_7b8d0f3abffeBkSA340yPBxwRs",
"type": "text",
"synthetic": true,
"text": "\u003Cfile\u003E\n00001| Hello MR. LLM\n00002| \n\u003C/file\u003E"
} |
3 tasks
pepperpepperpepper
pushed a commit
to pepperpepperpepper/opencode
that referenced
this pull request
Jul 29, 2025
achembarpu
pushed a commit
to achembarpu/opencode
that referenced
this pull request
Aug 4, 2025
xywsxp
pushed a commit
to xywsxp/opencode
that referenced
this pull request
Apr 24, 2026
bussard76
pushed a commit
to bussard76/openwork
that referenced
this pull request
May 12, 2026
* fix(docs): restore migrated share skill links Republish the example skill bundles on share.openworklabs.com so the docs point at live imports again, and align share bundle examples with the current publisher host. * fix(server): use canonical shared bundle data urls Rebuild trusted share fetch URLs to the share service's canonical /b/:id/data endpoint and cover the path with the live provider-config-helper bundle URL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #1330
Now I have tested this a variety of ways:
@ references (text & image)
drag & drop files that live within and outside of the cwd (text & image)
Maybe there is something I am missing here but at least for me this fixes all attachment bugs I have ran into