Skip to content

Issue #511 - $parentNodeScope is null and can not access $id#512

Merged
Voles merged 2 commits into
angular-ui-tree:masterfrom
joechimo:master
Jul 12, 2015
Merged

Issue #511 - $parentNodeScope is null and can not access $id#512
Voles merged 2 commits into
angular-ui-tree:masterfrom
joechimo:master

Conversation

@joechimo

@joechimo joechimo commented Jul 12, 2015

Copy link
Copy Markdown
Contributor

Encountered an ongoing issue after a recent merge into master to fix an edge case. The following was the error:

TypeError: Cannot read property '$id' of null
    at Object.dragInfo.apply (http://127.0.0.1:8080/js/vendor.js:31906:85)
    at http://127.0.0.1:8080/js/vendor.js:31595:30
    at Scope.$get.Scope.$eval (http://127.0.0.1:8080/js/vendor.js:14466:28)
    at Scope.$get.Scope.$apply (http://127.0.0.1:8080/js/vendor.js:14565:23)
    at link.dragEnd (http://127.0.0.1:8080/js/vendor.js:31594:36)
    at HTMLDocument.link.dragEndEvent (http://127.0.0.1:8080/js/vendor.js:31636:15)
    at HTMLDocument.eventHandler (http://127.0.0.1:8080/js/vendor.js:3032:21) undefined

Joseph Cimaszewski and others added 2 commits July 12, 2015 12:37
Fixed a recently added bug that was causing an error in the apply fun…
8544256 
…ction when checking for $parentNodeScope.$id when $parentNodeScope.$id was null. This happened 100% of the time when attempting to nest a node into another node if the source node was not positioned directly after the destination node.
@joechimo
Merge pull request #1 from joechimo/issues/511-error-on-dropped-paren…
b2d6ba3 
…tNodeScope-is-null

Issue angular-ui-tree#511 - $parentNodeScope is null and can not access $id
Voles pushed a commit that referenced this pull request Jul 12, 2015
Merge pull request #512 from joechimo/master
cbdb469 
Issue #511 - $parentNodeScope is null and can not access $id
@Voles
Voles merged commit cbdb469 into angular-ui-tree:master Jul 12, 2015
@Voles

Voles commented Jul 12, 2015

Copy link
Copy Markdown
Member

Thanks for your work! Merged.

@luciano-masuero luciano-masuero mentioned this pull request Jul 13, 2015
Closed
@marsanla

marsanla commented Jul 31, 2015

Copy link
Copy Markdown

Is this merge, updated in Bower?

@Voles

Voles commented Jul 31, 2015

Copy link
Copy Markdown
Member

Yes v2.7.0 is just released!

@marsanla

marsanla commented Aug 3, 2015

Copy link
Copy Markdown

thanks!! :)

@StefanCodes StefanCodes mentioned this pull request Aug 17, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joechimo @Voles @marsanla @StefanCodes