Fixing severe memory leak#421
Merged
Merged
Conversation
keyup event was retaining scope which was retaining html nodes, cleaning up on $destroy verified that this fixes memory leak this article gave me insight into the problem: http://www.codeproject.com/Articles/882966/Fixing-Memory-Leaks-in-AngularJS-and-other-JavaScr
samuv
pushed a commit
to samuv/angular-ui-tree
that referenced
this pull request
Mar 28, 2015
Contributor
Author
|
anybody here? |
|
Kether.. I noticed the leak in UI Tree too. Your fix worked. Thanks |
|
Can this be pulled to master (version 2.2.0)? |
|
+1 on pull to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
keyup event was retaining scope which was retaining html nodes, cleaning up on $destroy
verified that this fixes memory leak
this article gave me insight into the problem:
http://www.codeproject.com/Articles/882966/Fixing-Memory-Leaks-in-AngularJS-and-other-JavaScr