fix(typeahead): corrections for bugs #2293, #2535#2557
Conversation
|
@pkozlowski-opensource you mentioned nearly a month ago that you would release a v0.12.0 with a fix for the typeahead issue. I think this might be the PR you need ;) |
|
any chance this will get merged soon? |
|
(bump) We are having to use my fork because this is not merged. |
|
Landed, thnx so much @zackarychapple ! |
|
Just curious why would you make the same request instead of merging the request? |
|
@zackarychapple not sure what you mean... if you look at a0be450 you will notice that it is your commit (that is, you are an author) that was _ committed_ by me. So I didn't do any new request, I've just merged your commit, albeit not using GitHub's merge button but using a technique similar to git cherry picking. Does it clarify things? |
|
@pkozlowski-opensource ahh, fair enough. I was not sure how cherry picks were reflected in github. Is there a benefit to cherry picking on github vs merging PR's? If so I might want to look at doing that on a few repos I commit on. |
|
Any estimates on when 0.12 might be coming as I'm interested in using typeahead with Angular 1.3 RC0 and later without needing to have a manual modification to my angular-ui 0.11 sources that someone might accidentally clobber by updating. |
|
Note: typeahead broke for me with angular Similar issue broke with datepicker |
Fixes angular-ui#2474 Fixes angular-ui#2541 Fixes angular-ui#2293 Closes angular-ui#2535 Closes angular-ui#2557
fix for #2293 replaces #2535 since test coverage was never updated.