Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

fix(typeahead): corrections for bugs #2293, #2535#2557

Closed
zackarychapple wants to merge 1 commit into
angular-ui:masterfrom
zackarychapple:typeaheadFix
Closed

fix(typeahead): corrections for bugs #2293, #2535#2557
zackarychapple wants to merge 1 commit into
angular-ui:masterfrom
zackarychapple:typeaheadFix

Conversation

@zackarychapple

Copy link
Copy Markdown
Contributor

fix for #2293 replaces #2535 since test coverage was never updated.

@Siyfion

Siyfion commented Aug 13, 2014

Copy link
Copy Markdown

@pkozlowski-opensource you mentioned nearly a month ago that you would release a v0.12.0 with a fix for the typeahead issue. I think this might be the PR you need ;)

@Siyfion Siyfion mentioned this pull request Aug 13, 2014
@davisford

Copy link
Copy Markdown

any chance this will get merged soon?

@zackarychapple

Copy link
Copy Markdown
Contributor Author

(bump) We are having to use my fork because this is not merged.

@pkozlowski-opensource

Copy link
Copy Markdown
Member

Landed, thnx so much @zackarychapple !

@zackarychapple

Copy link
Copy Markdown
Contributor Author

Just curious why would you make the same request instead of merging the request?

@pkozlowski-opensource

Copy link
Copy Markdown
Member

@zackarychapple not sure what you mean... if you look at a0be450 you will notice that it is your commit (that is, you are an author) that was _ committed_ by me. So I didn't do any new request, I've just merged your commit, albeit not using GitHub's merge button but using a technique similar to git cherry picking. Does it clarify things?

@zackarychapple

Copy link
Copy Markdown
Contributor Author

@pkozlowski-opensource ahh, fair enough. I was not sure how cherry picks were reflected in github. Is there a benefit to cherry picking on github vs merging PR's? If so I might want to look at doing that on a few repos I commit on.

@dholcombe

Copy link
Copy Markdown

Any estimates on when 0.12 might be coming as I'm interested in using typeahead with Angular 1.3 RC0 and later without needing to have a manual modification to my angular-ui 0.11 sources that someone might accidentally clobber by updating.

@davisford

Copy link
Copy Markdown

Note: typeahead broke for me with angular 1.3 rc0 -- I forked this repo so I could pull in this fix, and it works fine, but something broke with more recent Angular versions related to $viewValue where it won't display the bound string in the input box, and instead shows [Object object]

Similar issue broke with datepicker

OronNadiv pushed a commit to lanetix/bootstrap that referenced this pull request Nov 18, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants