Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

Remove leading newline#2200

Closed
JeremyWeir wants to merge 1 commit into
angular-ui:masterfrom
JeremyWeir:patch-1
Closed

Remove leading newline#2200
JeremyWeir wants to merge 1 commit into
angular-ui:masterfrom
JeremyWeir:patch-1

Conversation

@JeremyWeir

Copy link
Copy Markdown
Contributor

This messes up jquery's parsing of the template

This messes up jquery's parsing of the template
@JeremyWeir

Copy link
Copy Markdown
Contributor Author

fixes the issue for jQuery 1.9, it seems to not be an issue for 1.11...

#2106

@chrisirhc

Copy link
Copy Markdown
Contributor

Thank you! Looks good. However, could you revise your commit message to follow our format? It look like be "fix(tabs): remove leading newline". Once you're done, you can update this pull request with the new commit. (Use git commit --amend to modify the commit message and then force an update to your patch-1 branch).

@pkozlowski-opensource

Copy link
Copy Markdown
Member

Thnx @JeremyWeir !

OronNadiv pushed a commit to lanetix/bootstrap that referenced this pull request Nov 18, 2014
This messes up jquery's parsing of the template

Closes angular-ui#2200
Fixes angular-ui#2106
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants