feat(chips): allow mdChips component to be used with 'data-'-prefixes#8002
feat(chips): allow mdChips component to be used with 'data-'-prefixes#8002janeisklar wants to merge 1 commit into
Conversation
Changes: * <md-chips>, <md-chip-template>, etc. can now also be used as <data-md-chips>, <data-md-chip-template> * added a basic usage demo that features those <data-*> tags * made the corresponding tests parametric so that they are executed both with and without the prefix 'data-'-prefixing is f.e. done by angular-htmlify and allows for the W3C validation of angular templates
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
1 similar comment
|
CLAs look good, thanks! |
| @@ -1,4 +1,4 @@ | |||
| md-chips.md-THEME_NAME-theme { | |||
| md-chips.md-THEME_NAME-theme, data-md-chips.md-THEME_NAME-theme { | |||
There was a problem hiding this comment.
I don't like that. This would require a selector for x- as well.
We should either apply a class, to identify the chips directive.
|
A generic solution to |
|
Is there an issue that you could reference allowing us to track the progress of the mentioned generic solution? |
Compare to pull request #7056 for a similar issue with md-menu
Changes:
<md-chips>,<md-chip-template>, etc. can now also be used as<data-md-chips>,<data-md-chip-template><data-*>tagsBackground:
'data-'-prefixing is f.e. done by angular-htmlify and allows for the W3C validation of angular templates