This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(progressLinear): sync logic, perf upgrades, fix animations#4454
Closed
ThomasBurleson wants to merge 1 commit into
Closed
fix(progressLinear): sync logic, perf upgrades, fix animations#4454ThomasBurleson wants to merge 1 commit into
ThomasBurleson wants to merge 1 commit into
Conversation
Contributor
Author
|
@robertmesserle, @topherfangio - ready for review. |
Contributor
|
Will dig into the code changes shortly, but when running locally, I noticed a small issue:
It appears identical to issue #4388. Originally, it seemed to happen every time I switched the demos, but since your (now next to latest) commit, it seems to happen less. |
Contributor
There was a problem hiding this comment.
Is there a particular reason why the formatting has extra indentation here?
Also, should it be mode() === MODE_DETERMINATE (i.e. with the triple =)?
Contributor
There was a problem hiding this comment.
Actually, contrary to what most of the JS world says, the Google JS styleguide uses == instead of ===. I struggle to break the === habit on this project. =p
fd26cd1 to
8bf7a8b
Compare
…ons, perf upgrades
synchronize progressLinear with similar logic used in progressCircular.
* improve animation performances
* watch md-mode for changes
* refactor animation SCSS
* enable hiding and no-animations with undefined/empty md-mode attributes
* for both indicators, use `display:inline-block;`
* update demos with enable switch
* fix query mode
* update Select to use enhanced progressCircular component
* fix autocomplete styling of progress-linear.md-mode-indeterminate
* auto-inject md-mode attribute if missing
* use 'determinate' if value attribute is defined
* otherwise use 'indeterminate'
* $log.debug() notify user (via $log.debug) of injection
* add API doc details regarding md-mode auto-injection
* fix tests
BREAKING-CHANGES
Before:
```css
md-progress-linear {
display: block;
}
md-progress-circular {
// display not set
// position not set
}
```
```css
md-progress-linear {
display: inline-block;
position: relative;
}
md-progress-circular {
display: inline-block;
position: relative;
}
```
Fixes #4421. Fixes #4409. Fixes #2540. Fixes #2364. Fixes #1926. Fixes #3802.
kennethcachia
pushed a commit
to kennethcachia/material
that referenced
this pull request
Sep 23, 2015
…ons, perf upgrades
synchronize progressLinear with similar logic used in progressCircular.
* improve animation performances
* watch md-mode for changes
* refactor animation SCSS
* enable hiding and no-animations with undefined/empty md-mode attributes
* for both indicators, use `display:inline-block;`
* update demos with enable switch
* fix query mode
* update Select to use enhanced progressCircular component
* fix autocomplete styling of progress-linear.md-mode-indeterminate
* auto-inject md-mode attribute if missing
* use 'determinate' if value attribute is defined
* otherwise use 'indeterminate'
* $log.debug() notify user (via $log.debug) of injection
* add API doc details regarding md-mode auto-injection
* fix tests
BREAKING-CHANGES
Before:
```css
md-progress-linear {
display: block;
}
md-progress-circular {
// display not set
// position not set
}
```
```css
md-progress-linear {
display: block;
position: relative;
}
md-progress-circular {
display: block;
position: relative;
}
```
Fixes angular#4421. Fixes angular#4409. Fixes angular#2540. Fixes angular#2364. Fixes angular#1926. Fixes angular#3802. Closes angular#4454.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
synchronize progressLinear with similar logic used in progressCircular.
display:inline-block;BREAKING-CHANGES
Before:
Fixes #4421. Fixes #4409. Fixes #2540. Fixes #2364. Fixes #1926. Fixes #3802.