Skip to content
This repository was archived by the owner on Apr 4, 2025. It is now read-only.

fix(@angular-devkit/build-optimizer): don't exceed call stack with bi…#998

Merged
hansl merged 1 commit into
angular:masterfrom
filipesilva:build-opt-big-file
Jun 4, 2018
Merged

fix(@angular-devkit/build-optimizer): don't exceed call stack with bi…#998
hansl merged 1 commit into
angular:masterfrom
filipesilva:build-opt-big-file

Conversation

@filipesilva
Copy link
Copy Markdown
Contributor

@filipesilva filipesilva requested a review from clydin as a code owner June 1, 2018 11:58
@filipesilva
Copy link
Copy Markdown
Contributor Author

We cannot update the repository itself to use TypeScript 2.9.1 because the Angular Compiler itself does not yet support it.

We can perhaps, update just the @angular-devkit/build-optimizer dependency. I manually checked all the build optimizer unit and integration tests and everything seems to pass with TS 2.9.1.

The exception is some of the prefix-classes unit tests, where we compare output assuming TS does not preserve all comments (microsoft/TypeScript#22141). A lot of these seem to be fixed in 2.9.1 so our tests fail there.

Changing the tests to account for comments not being dropped is easy but shouldn't be done right now, because we still test against 2.7.2.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants