fix(core): raise the rxfire floor to ^6.2.0 for its firebase 12 peers#3723
Open
armando-navarro wants to merge 1 commit into
Open
fix(core): raise the rxfire floor to ^6.2.0 for its firebase 12 peers#3723armando-navarro wants to merge 1 commit into
armando-navarro wants to merge 1 commit into
Conversation
rxfire 6.1.0 peers firebase ^9||^10||^11, so npm installs a second firebase 11 next to @angular/fire's firebase 12 and the first Firestore read throws "Type does not match the expected instance". rxfire 6.2.0 (the peer-range fix, rxfire#152) is on npm latest since 2026-07-22. ^6.1.0 already resolves to 6.2.0 on fresh installs; the raised floor is for upgraders whose lockfile pins rxfire 6.1.0, which survives an @angular/fire upgrade and recreates the dual-SDK tree. ^6.2.0 forces the bump. Also drop the root overrides block that forced rxfire's firebase peer to ^12.4.0 in this repo's own tree (obsolete with 6.2.0), and sync the lockfile's stale root version 21.0.0-next.0 to 21.0.0-rc.0 to match package.json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rxfire 6.2.0 shipped to npm
lateston July 22, 2026 with firebase 12 in its peer range (FirebaseExtended/rxfire#152). This PR raises our dependency floor to require it.Background
^9 || ^10 || ^11as peers.@angular/fireonmaindepends onfirebase ^12.4.0, so a tree holding rxfire 6.1.0 gets a second firebase 11 installed next to firebase 12 (or, at best, an invalid-peer marker).Type does not match the expected instance. Did you pass a reference from a different Firestore SDK?.^9 || ^10 || ^11 || ^12and contains no other runtime change (the only other commit between 6.1.0 and 6.2.0 is CI-only).What this changes
src/package.json:rxfire^6.1.0to^6.2.0(the range the published package ships).package.json: the same bump, and removes theoverridesblock that forced rxfire's firebase peer to^12.4.0in this repo's own install tree; rxfire 6.2.0 makes it unnecessary.package-lock.json: rxfire moves to 6.2.0; npm also synced the lockfile's stale root version21.0.0-next.0to21.0.0-rc.0, matchingpackage.json.Why raise the floor when ^6.1.0 already resolves to 6.2.0
Fresh installs are unaffected: a clean project installing
@angular/fire@21.0.0-rc.0today already resolves rxfire 6.2.0 and a single firebase (verified). The floor is for upgrades: a lockfile that pins rxfire 6.1.0 satisfies^6.1.0, survives an@angular/fireupgrade, and rxfire 6.1.0's peer set then re-creates the duplicate firebase 11. With^6.2.0the upgrade is forced onto the fixed release.What this does not fix
An app whose own
firebasedependency stays on 11.x still ends up with two SDK copies: rxfire binds the root firebase 11 while@angular/firenests firebase 12. That is the mechanism behind #3684, #3681, and #3682, and the fix there is upgrading the app'sfirebaseto^12together with@angular/fire; a schematics follow-up and the release notes will cover that path. Refs #3666.Verification
21.0.0-rc.0: resolves rxfire 6.2.0, onefirebase@12.16.0(rxfire's copy deduped), one@firebase/firestore.npm run build: the packed tarball'spackage.jsoncarriesrxfire: ^6.2.0.