Skip to content

fix: Avoid handling promise rejections twice in stability helper #3657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesdaniels merged 1 commit into from
Jun 12, 2025
+2 −2
Merged

fix: Avoid handling promise rejections twice in stability helper #3657

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: Avoid handling promise rejections twice in stability helper 
`PendingTasks.run` reports rejections of the promise to the
`ErrorHandler`. This function already returns a promise that is meant to
be handled in the developer's application. If there _is_ handling there,
the rejection is handled both in the `PendingTasks.run` and in the
developer callsite.

This change updates the code to use `PendingTasks.add` instead, which
has no built in error handling mechanisms.

fixes angular/angular#61932
  • Loading branch information
@atscott
atscott committed Jun 6, 2025
commit 695d4c5f81cc8af2ec243e6a685e1ce5c41fbaaa
4 changes: 2 additions & 2 deletions src/zones.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,12 +170,12 @@ export const ɵzoneWrap = <T= unknown>(it: T, blockUntilFirst: boolean, logLevel
// eslint-disable-next-line @typescript-eslint/no-misused-promises
return run(
() => {
pendingTasks.run(() => ret);
const removeTask = pendingTasks.add();
return new Promise((resolve, reject) => {
ret.then(
(it) => runInInjectionContext(injector, () => run(() => resolve(it))),
(reason) => runInInjectionContext(injector, () => run(() => reject(reason)))
)
).finally(removeTask);
});
});
} else if (typeof ret === 'function' && taskDone) {
Expand Down