Skip to content

Zone docs and switch to warnings #3608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesdaniels merged 3 commits into from
Jan 10, 2025
+23 −2
Merged

Zone docs and switch to warnings #3608

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
89ae38a
Warn rather than error, thats trippin folk
jamesdaniels Jan 9, 2025
ebd5d31
Add doc on zone wrappers
jamesdaniels Jan 9, 2025
2eea611
Words
jamesdaniels Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Warn rather than error, thats trippin folk
  • Loading branch information
@jamesdaniels
jamesdaniels committed Jan 9, 2025
commit 89ae38a9332dc0f790fbc44a8e5178ab906aa1cb
4 changes: 2 additions & 2 deletions src/zones.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,11 @@ function getSchedulers() {
var alreadyWarned = false;
function warnOutsideInjectionContext(original: any, operation: string) {
if (isDevMode()) {
console.warn(`Firebase API called outside injection context: ${operation}(${original.name})`);
if (!alreadyWarned) {
alreadyWarned = true;
console.error("Calling Firebase APIs outside of an Injection context may destabilize your application leading to subtle change-detection and hydration bugs. Find more at https://github.com/angular/angularfire/blob/main/docs/zones.md");
console.warn("Calling Firebase APIs outside of an Injection context may destabilize your application leading to subtle change-detection and hydration bugs. Find more at https://github.com/angular/angularfire/blob/main/docs/zones.md");
}
console.warn(`Firebase API called outside injection context: ${operation}(${original.name})`);
}
}

Expand Down