Skip to content

Adding more injector safety #3590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesdaniels merged 4 commits into from
Dec 13, 2024
Merged

Adding more injector safety #3590

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5fff7af
Adding more injector safety
jamesdaniels Dec 13, 2024
a401cdb
better warning
jamesdaniels Dec 13, 2024
a184f69
Pass injector scope to promises
jamesdaniels Dec 13, 2024
8275675
beforeAuthStateChanged should not block
jamesdaniels Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Pass injector scope to promises
  • Loading branch information
@jamesdaniels
jamesdaniels committed Dec 13, 2024
commit a184f69f7f82b432e48e80e7db56383e1b8cf4b6
6 changes: 3 additions & 3 deletions src/zones.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ function getSchedulers() {
var alreadyWarned = false;
function warnOutsideInjectionContext(original: any, operation: string) {
if (isDevMode()) {
console.warn(`Firebase API called outside injection context: ${operation}(${original})`);
console.warn(`Firebase API called outside injection context: ${operation}(${original.name})`);
if (!alreadyWarned) {
alreadyWarned = true;
console.error("Calling Firebase APIs outside of an Injection context may destabilize your application leading to subtle change-detection and hydration bugs. Find more at https://github.com/angular/angularfire/blob/main/docs/zones.md");
Expand Down Expand Up @@ -196,8 +196,8 @@ export const ɵzoneWrap = <T= unknown>(it: T, blockUntilFirst: boolean): T => {
() =>
new Promise((resolve, reject) => {
pendingTasks.run(() => ret).then(
(it) => run(() => resolve(it)),
(reason) => run(() => reject(reason))
(it) => runInInjectionContext(injector, () => run(() => resolve(it))),
(reason) => runInInjectionContext(injector, () => run(() => reject(reason)))
);
})
);
Expand Down