Skip to content

Checking for window.performance.mark, may fix #2812#2813

Closed
spicemix wants to merge 2 commits intoangular:masterfrom
spicemix:master
Closed

Checking for window.performance.mark, may fix #2812#2813
spicemix wants to merge 2 commits intoangular:masterfrom
spicemix:master

Conversation

@spicemix
Copy link
Copy Markdown

@spicemix spicemix commented May 4, 2021

Checklist

  • Issue number for this PR: AngularFirePerformance incompatible with Jest #2812 (required)
  • Docs included?: no (yes/no; required for all API/functional changes)
  • Test units included?: no (yes/no; required)
  • In a clean directory, yarn install, yarn test run successfully? yes (yes/no; required)

Description

Trivial bugfix for Jest compatibility

Code sample

spicemix added 2 commits May 4, 2021 00:42
For compatibility with test environments that replace window.performance
For compatibility with test environments that replace window.performance
@jamesdaniels
Copy link
Copy Markdown
Member

Thanks, resolving merge conflicts here #2920

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants