This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Why should watchExpression should be idempotent?#9963
Closed
btelles wants to merge 2 commits into
Closed
Conversation
This attempts to clarify the rationale. The Previous sentence was a bit ambiguous. If this new explanation does not reflect the intent, please use its active voice (as opposed to passive voice) as a template to clarify the existing sentence.
Contributor
|
this is fine, but one thing I might do is add a link to the definition of idempotent, since it's not in most peoples vocabularies (and this has been acknowledged numerous times during talks on the subject). |
Contributor
|
Feel free to ping me once it's a bit more useful to people, and I'll be happy to land it :) |
Update description.
Contributor
Author
|
Allright, took me a while, but I got around to it. Hope this addresses it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This attempts to clarify the rationale. The Previous sentence was a bit ambiguous. If this new explanation does not reflect the intent, please use its active voice (as opposed to passive voice) as a template to clarify the existing sentence.