docs(tutorial/4 - Two-way Data Binding): describe your change...#9823
docs(tutorial/4 - Two-way Data Binding): describe your change...#9823kboutsen wants to merge 1 commit into
Conversation
var phoneNameColumn = element.all(by.repeater('phone in phones').column('{{phone.name}}'));
should be
var phoneNameColumn = element.all(by.repeater('phone in phones').column('phone.name'));
|
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
|
I have just signed the CLA |
|
It looks good to me |
|
I think that in the documentation the statetement ....column('{{phone.name}}')... is wrong. On the Git source it is correctly ....column('phone.name')... The documentation should be updated with ....column('phone.name')... |
|
I already filed a bug on ptor to update the docs, but I'm probably not going to write a patch for it. Feel free to do that though angular/protractor#1480 |
var phoneNameColumn = element.all(by.repeater('phone in phones').column('{{phone.name}}'));
should be
var phoneNameColumn = element.all(by.repeater('phone in phones').column('phone.name'));