Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs($http): patch method is not exists#9763

Closed
luruke wants to merge 1 commit into
angular:v1.2.xfrom
luruke:patch-1
Closed

docs($http): patch method is not exists#9763
luruke wants to merge 1 commit into
angular:v1.2.xfrom
luruke:patch-1

Conversation

@luruke

@luruke luruke commented Oct 23, 2014

Copy link
Copy Markdown

The link here brings nowhere.
On the 1.2.6 the patch method seems not exists / not working.

You can observe the error here:
http://plnkr.co/edit/cwJ1pgoqbBUzjSoApg5S
TypeError: undefined is not a function

If you just change the version of angular with 1.3.0 the request will work.

The link here brings nowhere.
On the 1.2.6 the patch method seems not exists / not working.

You can observe the error here:
http://plnkr.co/edit/cwJ1pgoqbBUzjSoApg5S
`TypeError: undefined is not a function`

If you just change the version of angular with 1.3.0 the request will work.
@mary-poppins

Copy link
Copy Markdown

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@luruke

luruke commented Oct 23, 2014

Copy link
Copy Markdown
Author

Sorry. I just signed it now.

@gkalpak

gkalpak commented Oct 23, 2014

Copy link
Copy Markdown
Member

This has been already fixed with #9321.
(Should be included in the next 1.2.x release.)

@luruke: BTW, make sure you check against the latest stable version of the branch in question. I.e. you should have checked against 1.2.26 (which is the latest 1.2.x version). This is because fixes always go into the latest stable version (so 1.2.6 will never have a patch() method, but 1.2.27 will).
This time it wouldn't have made any real difference, but next time it might :)

@luruke

luruke commented Oct 24, 2014

Copy link
Copy Markdown
Author

Thank you @gkalpak and sorry for not checked if this issue has been already reported.

@luruke luruke closed this Oct 24, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants