This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Fix issues with ngShow / ngHide animations#9493
Closed
matsko wants to merge 2 commits into
Closed
Conversation
5db9c39 to
8007a3e
Compare
…during animations Prior to this fix if an element that contained ng-show or ng-hide was in its hidden state then any other animation run on the same element would cause the animation to appear despite the element itself already being hidden. This patch ensures that NO animations are visible even if the element is set as hidden. Closes angular#9103
8007a3e to
000da62
Compare
Member
AngularJSThe Superheroic JavaScript MVW Framework that hides your animations even if the element is hidden !!!(pun intended ?) |
abdaab7 to
30996f8
Compare
matsko
added a commit
that referenced
this pull request
Oct 8, 2014
…during animations Prior to this fix if an element that contained ng-show or ng-hide was in its hidden state then any other animation run on the same element would cause the animation to appear despite the element itself already being hidden. This patch ensures that NO animations are visible even if the element is set as hidden. Closes #9103 Closes #9493
bullgare
pushed a commit
to bullgare/angular.js
that referenced
this pull request
Oct 9, 2014
bullgare
pushed a commit
to bullgare/angular.js
that referenced
this pull request
Oct 9, 2014
…during animations Prior to this fix if an element that contained ng-show or ng-hide was in its hidden state then any other animation run on the same element would cause the animation to appear despite the element itself already being hidden. This patch ensures that NO animations are visible even if the element is set as hidden. Closes angular#9103 Closes angular#9493
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix($animate): ensure hidden elements with ngShow/ngHide stay hidden during animations
Prior to this fix if an element that contained ng-show or ng-hide was in its hidden state
then any other animation run on the same element would cause the animation to appear despite
the element itself already being hidden. This patch ensures that NO animations are visible
even if the element is set as hidden.
Closes #9103