This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngEventDirs): check scope.$$phase only on $rootScope#8849
Closed
shahata wants to merge 2 commits into
Closed
Conversation
Contributor
|
Didn't know that one. Is it possible to show that in a test? |
Contributor
Author
|
I already am showing it in the test... |
Contributor
|
@shahata Thanks for catching this! |
Closed
tbosch
pushed a commit
that referenced
this pull request
Sep 2, 2014
tbosch
pushed a commit
that referenced
this pull request
Sep 2, 2014
Contributor
|
Landed in master via 203ea10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checking
scope.$$phaseis dangerous since it does not work on isolated scopes. It exists only on$rootScope, and isolated scopes do not inherit it.