Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Remove duplicate $digest()#8840

Closed
gitMbar wants to merge 1 commit into
angular:masterfrom
gitMbar:master
Closed

Remove duplicate $digest()#8840
gitMbar wants to merge 1 commit into
angular:masterfrom
gitMbar:master

Conversation

@gitMbar

@gitMbar gitMbar commented Aug 29, 2014

Copy link
Copy Markdown
Contributor

Seems like the same event was added twice on accident. Perhaps something else was meant in place of the second $digest() but as it stands it is confusing.

@mary-poppins

Copy link
Copy Markdown

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@caitp

caitp commented Aug 29, 2014

Copy link
Copy Markdown
Contributor

I'm not sure why it's talking about "digest" and "events" in the same sentence at all. Those are probably supposed to be talking about broadcast and emit rather than digest.

@caitp

caitp commented Aug 29, 2014

Copy link
Copy Markdown
Contributor

/cc @petebacondarwin (this was you 4a6a3ba)

@petebacondarwin

Copy link
Copy Markdown
Contributor

@caitp - actually all my commit changed was the link.

@caitp

caitp commented Aug 29, 2014

Copy link
Copy Markdown
Contributor

Actually I'm wrong, that comment goes back a lot further than that commit :x -- yeah, that line has changed a few times, but the intent of the line never seems to have been questioned, it goes back a few years

@caitp

caitp commented Aug 29, 2014

Copy link
Copy Markdown
Contributor

Here we go, looks like it was this: 42062da --- I guess we used to have $flush and $digest. Yeah this looks right, just remove the second $digest and it makes sense.

@caitp

caitp commented Aug 29, 2014

Copy link
Copy Markdown
Contributor

Anyways yeah, lgtm --- just surprised it took so long to be corrected :p I'm still not sure why we're calling it an "event", but I guess it works

@gitMbar

gitMbar commented Aug 29, 2014

Copy link
Copy Markdown
Contributor Author

caitp - should I close this and open a new pull request with $flush and $digest?

@caitp

caitp commented Aug 29, 2014

Copy link
Copy Markdown
Contributor

no, $flush was removed years ago --- I'm merging this, just fixing the trailing whitespace first

@gitMbar

gitMbar commented Aug 29, 2014

Copy link
Copy Markdown
Contributor Author

Cool, thanks

caitp pushed a commit that referenced this pull request Aug 29, 2014
@caitp caitp closed this in 4f9ac07 Aug 29, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants